Issue 2214 - Add message to Adblock Plus home page about mobile beta launch (CMS)

Anwiki:
http://codereview.adblockplus.org/4726834268733440/

Anwiki infrastructure:
http://codereview.adblockplus.org/6193426550751232/

Related ticket:
https://issues.adblockplus.org/ticket/2214

[saroyanm, 2015-05-18 16:24:36]

Sebastian please note that the CSS files (Anwiki infrastructure) are identical,
so I don't think it make sense to also review them, in case let me know.

[Sebastian Noack, 2015-05-18 16:34:31]

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
File includes/index.tmpl (right):

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
I don't think there is much sense in using <fix> to exclude that space from the
trasnlation.

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
Nit: If you use single spaces for the surrounding string, you don't need to
escape the double quotes within.

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
Any reason why you use a names message id here, as ooposed to sN like everywhere
else?

[saroyanm, 2015-05-18 17:13:45]

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
File includes/index.tmpl (right):

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
On 2015/05/18 16:34:31, Sebastian Noack wrote:
> I don't think there is much sense in using <fix> to exclude that space from
the
> trasnlation.

Done.

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
On 2015/05/18 16:34:31, Sebastian Noack wrote:
> Nit: If you use single spaces for the surrounding string, you don't need to
> escape the double quotes within.

Done.

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
On 2015/05/18 16:34:31, Sebastian Noack wrote:
> Any reason why you use a names message id here, as ooposed to sN like
everywhere
> else?

Not to change all the strings after and I was thinking s27.5 wasn't good idea as
well.

[Sebastian Noack, 2015-05-18 17:37:12]

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
File includes/index.tmpl (right):

http://codereview.adblockplus.org/4992283212513280/diff/5629499534213120/incl...
includes/index.tmpl:104: {{"Be the first to experience the new Adblock Browser
for smartphones and tablets.<fix> </fix><a href=\"adblock-browser\">Get it
here.</a>"|translate("adblock-browser-notification")}}
On 2015/05/18 17:13:46, saroyanm wrote:
> On 2015/05/18 16:34:31, Sebastian Noack wrote:
> > Any reason why you use a names message id here, as ooposed to sN like
> everywhere
> > else?
> 
> Not to change all the strings after and I was thinking s27.5 wasn't good idea
as
> well.

I wonder what's the plan for the message IDs in the long term, Wladimir? We
could either increase the numbers independent of the position, or use named
message ids like this here for new translations?

[Sebastian Noack, 2015-05-18 18:00:26]

After talking to Wladimir, I learned that message IDs for new translations are
supposed to be descriptive. So this is LGTM. But you should use meaningful named
message IDs in the other patch as well.

[saroyanm, 2015-05-18 18:23:40]

On 2015/05/18 18:00:26, Sebastian Noack wrote:
> After talking to Wladimir, I learned that message IDs for new translations are
> supposed to be descriptive. So this is LGTM. But you should use meaningful
named
> message IDs in the other patch as well.

The other patch updated.

[saroyanm, 2015-05-18 19:37:46]

@Ross here also you can apply only changes with delta from patchset number 1.
In case of question please let me know. 
Again it's just small changes.