Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(199)

Issue 5040954746601472: Issue 186 - disabled ABP icon in tool bar re-appears after seamonkey restart (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by saroyanm
Modified:
5 years, 9 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is related to current ticket: https://issues.adblockplus.org/ticket/186

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check for localname #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/customizableUI.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
saroyanm
Wladimir can you please have a look when you have time, I guess this review ...
5 years, 9 months ago (2014-05-06 12:19:46 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5040954746601472/diff/5629499534213120/lib/customizableUI.js File lib/customizableUI.js (right): http://codereview.adblockplus.org/5040954746601472/diff/5629499534213120/lib/customizableUI.js#newcode187 lib/customizableUI.js:187: if (node && node.parentNode.id != "BrowserToolbarPalette") Please check |node.parentNode.localName ...
5 years, 9 months ago (2014-05-08 13:40:21 UTC) #2
saroyanm
Uploaded a new patch with your mentioned change Wladimir. http://codereview.adblockplus.org/5040954746601472/diff/5629499534213120/lib/customizableUI.js File lib/customizableUI.js (right): http://codereview.adblockplus.org/5040954746601472/diff/5629499534213120/lib/customizableUI.js#newcode187 lib/customizableUI.js:187: ...
5 years, 9 months ago (2014-05-08 15:13:13 UTC) #3
Wladimir Palant
5 years, 9 months ago (2014-05-08 18:03:32 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5