Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5046426828537856: Issue 1485 - Created Maxthon landing page (Infrastructure) (Closed)

Created:
Oct. 24, 2014, 10:18 a.m. by Thomas Greiner
Modified:
Nov. 14, 2014, 9:54 a.m.
Visibility:
Public.

Description

Websites module changes: http://codereview.adblockplus.org/6336478909038592/

Patch Set 1 #

Patch Set 2 : Added missing "/" in user agent regex #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M anwiki/_override-static/global/global/css/index.css View 3 chunks +43 lines, -1 line 2 comments Download
M anwiki/_override-static/global/global/css/index-mobile.css View 1 chunk +1 line, -1 line 0 comments Download
A anwiki/_override-static/global/global/img/maxthon-teaser.png View Binary file 0 comments Download
M puppet/modules/adblockplusorg/files/adblockplus.org View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Thomas Greiner
Oct. 24, 2014, 10:25 a.m. (2014-10-24 10:25:25 UTC) #1
saroyanm
http://codereview.adblockplus.org/5046426828537856/diff/5649050225344512/anwiki/_override-static/global/global/css/index.css File anwiki/_override-static/global/global/css/index.css (right): http://codereview.adblockplus.org/5046426828537856/diff/5649050225344512/anwiki/_override-static/global/global/css/index.css#newcode33 anwiki/_override-static/global/global/css/index.css:33: padding: 0px; Not that much matter, but should we ...
Oct. 24, 2014, 4 p.m. (2014-10-24 16:00:25 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/5046426828537856/diff/5649050225344512/anwiki/_override-static/global/global/css/index.css File anwiki/_override-static/global/global/css/index.css (right): http://codereview.adblockplus.org/5046426828537856/diff/5649050225344512/anwiki/_override-static/global/global/css/index.css#newcode33 anwiki/_override-static/global/global/css/index.css:33: padding: 0px; On 2014/10/24 16:00:25, saroyanm wrote: > Not ...
Oct. 27, 2014, 10:58 a.m. (2014-10-27 10:58:16 UTC) #3
Wladimir Palant
I didn't review the CSS part (trusting you and Manvel on this), LGTM for the ...
Nov. 10, 2014, 3:37 p.m. (2014-11-10 15:37:30 UTC) #4
saroyanm
Nov. 13, 2014, 1:03 p.m. (2014-11-13 13:03:31 UTC) #5
On 2014/11/10 15:37:30, Wladimir Palant wrote:
> I didn't review the CSS part (trusting you and Manvel on this), LGTM for the
> rest.

My Concern, was just about 0px, but now it's clear, so LGTM for CSS part.

Powered by Google App Engine
This is Rietveld