Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5046550090743808: Issue 1623 - Removed unused/duplicate translations (Closed)

Created:
Nov. 27, 2014, 10:47 a.m. by Sebastian Noack
Modified:
Dec. 3, 2014, 9:05 a.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1623 - Removed unused/duplicate translations

Patch Set 1 #

Total comments: 4

Patch Set 2 : Keep duplicate translation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M _locales/en_US/messages.json View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Nov. 27, 2014, 10:48 a.m. (2014-11-27 10:48:23 UTC) #1
kzar
LGTM
Dec. 1, 2014, 1:22 p.m. (2014-12-01 13:22:03 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_locales/en_US/messages.json File _locales/en_US/messages.json (left): http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_locales/en_US/messages.json#oldcode55 _locales/en_US/messages.json:55: "message": "Block element" I'm not sure that this is ...
Dec. 1, 2014, 7:39 p.m. (2014-12-01 19:39:43 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_locales/en_US/messages.json File _locales/en_US/messages.json (left): http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_locales/en_US/messages.json#oldcode55 _locales/en_US/messages.json:55: "message": "Block element" On 2014/12/01 19:39:43, Wladimir Palant wrote: ...
Dec. 2, 2014, 9:26 a.m. (2014-12-02 09:26:13 UTC) #4
Wladimir Palant
Dec. 2, 2014, 2:46 p.m. (2014-12-02 14:46:35 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld