Issue 1623 - Removed unused/duplicate translations

Issue 1623 - Removed unused/duplicate translations

[kzar, 2014-12-01 13:22:03]

LGTM

[Wladimir Palant, 2014-12-01 19:39:43]

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
File _locales/en_US/messages.json (left):

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
_locales/en_US/messages.json:55: "message": "Block element"
I'm not sure that this is a good idea. A button and a dialog title are two
different things, even if they refer to the same feature. I'd definitely veto
this change if there were a chance that we decide to change these strings at
some point - it's just too likely that we'd want different strings here. But
even for a deprecated UI and assuming that you checked that all the translations
are indeed identical, I don't see why we should remove this string. It's not
like doing so will reduce the work the translators need to do (Crowdin has
translation memory so identical strings don't need to be translated twice).

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
File _locales/en_US/messages.json (right):

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
_locales/en_US/messages.json:23: "message": "Block element"
Actually, it should probably be in title case. The problem is rather than our
other titles aren't using it.

[Sebastian Noack, 2014-12-02 09:26:13]

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
File _locales/en_US/messages.json (left):

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
_locales/en_US/messages.json:55: "message": "Block element"
On 2014/12/01 19:39:43, Wladimir Palant wrote:
> I'm not sure that this is a good idea. A button and a dialog title are two
> different things, even if they refer to the same feature. I'd definitely veto
> this change if there were a chance that we decide to change these strings at
> some point - it's just too likely that we'd want different strings here. But
> even for a deprecated UI and assuming that you checked that all the
translations
> are indeed identical, I don't see why we should remove this string. It's not
> like doing so will reduce the work the translators need to do (Crowdin has
> translation memory so identical strings don't need to be translated twice).

I think we should make sure they have the same title, for consistency and that
the users knows they are the same feature. I don't see any difference between an
item in the popup UI, and an item in the context menu. But fair enough. It's
probably not worth arguing.

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
File _locales/en_US/messages.json (right):

http://codereview.adblockplus.org/5046550090743808/diff/5629499534213120/_loc...
_locales/en_US/messages.json:23: "message": "Block element"
On 2014/12/01 19:39:43, Wladimir Palant wrote:
> Actually, it should probably be in title case. The problem is rather than our
> other titles aren't using it.

It should be consistent with the other labels. While we could change the other
labels in popup UI, we can't change the other items in the context menu, which
aren't title-ized, e.g. "Inspect element".

[Wladimir Palant, 2014-12-02 14:46:35]

LGTM