chrome/content/ui/filters-filterview.js - Issue 5062082168881152: NO BUG Allow users to disable element hiding

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/filters-filterview.js

Issue 5062082168881152: NO BUG Allow users to disable element hiding (Closed)

Patch Set: Created Feb. 18, 2015, 1:47 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/content/ui/filters-filterview.js

===================================================================

--- a/chrome/content/ui/filters-filterview.js

+++ b/chrome/content/ui/filters-filterview.js

@@ -642,19 +642,19 @@ var FilterView =

this.noFiltersDummy = {index: 0, filter: {text: this.boxObject.treeBody.getAttribute("noFiltersText"), dummy: true}};

this.editDummy = {filter: {text: ""}};

let atomService = Cc["@mozilla.org/atom-service;1"].getService(Ci.nsIAtomService);

let stringAtoms = ["col-filter", "col-enabled", "col-hitcount", "col-lasthit", "type-comment", "type-filterlist", "type-whitelist", "type-elemhide", "type-elemhideexception", "type-invalid"];

let boolAtoms = ["selected", "dummy", "slow", "disabled"];

this.atoms = {};

- for each (let atom in stringAtoms)

+ for (let atom of stringAtoms)

this.atoms[atom] = atomService.getAtom(atom);

- for each (let atom in boolAtoms)

+ for (let atom of boolAtoms)

{

this.atoms[atom + "-true"] = atomService.getAtom(atom + "-true");

this.atoms[atom + "-false"] = atomService.getAtom(atom + "-false");

}

let columns = this.boxObject.columns;

for (let i = 0; i < columns.length; i++)

if (columns[i].element.hasAttribute("sortDirection"))

« no previous file with comments | « chrome/content/ui/filters.xul ('k') | chrome/content/ui/filters-subscriptionview.js » ('j') | no next file with comments »