Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5085502482939904: Specify an additional 38px default icon for the browserAction (Closed)

Created:
April 4, 2014, 9:03 a.m. by Sebastian Noack
Modified:
April 4, 2014, 11:18 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

With http://codereview.adblockplus.org/5838171610808320/, I added high resolution icons for Retina displays. However I forgot to add the larger icon also to the default icon configuration in the generated manifest.json.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M .hgsubstate View 1 1 chunk +1 line, -1 line 0 comments Download
M metadata.chrome View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
April 4, 2014, 9:11 a.m. (2014-04-04 09:11:19 UTC) #1
Wladimir Palant
LGTM
April 4, 2014, 10:52 a.m. (2014-04-04 10:52:52 UTC) #2
Sebastian Noack
On 2014/04/04 10:52:52, Wladimir Palant wrote: > LGTM Sorry, I uploaded the wrong patch set ...
April 4, 2014, 10:57 a.m. (2014-04-04 10:57:15 UTC) #3
Wladimir Palant
April 4, 2014, 10:58 a.m. (2014-04-04 10:58:42 UTC) #4
LGTM on the new patchset as well.

Powered by Google App Engine
This is Rietveld