Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5092502491103232: Deal with preloadded pages in Safari 7.0 (Closed)

Created:
Jan. 23, 2014, 2:03 p.m. by Sebastian Noack
Modified:
Feb. 24, 2014, 12:49 p.m.
Visibility:
Public.

Description

Safari 7.0 runs content scripts in preloaded pages. However our high-level code expects only the page that the user can see, to be running in a tab. So we have to defer all requests from preloaded pages to the background page until the page is shown.

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -20 lines) Patch
M safari/ext/background.js View 1 6 chunks +81 lines, -7 lines 0 comments Download
M safari/ext/common.js View 2 chunks +2 lines, -2 lines 0 comments Download
M safari/ext/content.js View 1 7 chunks +95 lines, -11 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 23, 2014, 2:12 p.m. (2014-01-23 14:12:07 UTC) #1
Wladimir Palant
I didn't finish this review, IMHO we are trying to save a leaky abstraction here. ...
Jan. 24, 2014, 2:11 p.m. (2014-01-24 14:11:34 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5092502491103232/diff/5629499534213120/safari/ext/background.js File safari/ext/background.js (right): http://codereview.adblockplus.org/5092502491103232/diff/5629499534213120/safari/ext/background.js#newcode80 safari/ext/background.js:80: this._preloadedTabs.delete(tab); On 2014/01/24 14:11:34, Wladimir Palant wrote: > What ...
Jan. 24, 2014, 2:17 p.m. (2014-01-24 14:17:49 UTC) #3
Sebastian Noack
Feb. 24, 2014, 12:49 p.m. (2014-02-24 12:49:36 UTC) #4
This patch became obsolete in favor of
http://codereview.adblockplus.org/5464830253203456/

Powered by Google App Engine
This is Rietveld