safari/ext/common.js - Issue 5092502491103232: Deal with preloadded pages in Safari 7.0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: safari/ext/common.js

Issue 5092502491103232: Deal with preloadded pages in Safari 7.0 (Closed)

Patch Set: Created Jan. 23, 2014, 3:21 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: safari/ext/common.js

===================================================================

--- a/safari/ext/common.js

+++ b/safari/ext/common.js

@@ -69,7 +69,7 @@

{

return function(event)

{

- if (event.name == "request")

+ if (event.name == "request" && !this._ignoreIf(event))

listener(event.message.payload, this._getSenderDetails(event), function(message)

{

this._getResponseDispatcher(event).dispatchMessage("response",

@@ -98,7 +98,7 @@

if (event.name == "response" && event.message.requestId == requestId)

{

responseEventTarget.removeEventListener("message", responseListener, false);

- responseCallback(event.message.payload);

+ responseCallback(event.message);

}

};

responseEventTarget.addEventListener("message", responseListener, false);

« no previous file with comments | « safari/ext/background.js ('k') | safari/ext/content.js » ('j') | no next file with comments »