Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5092904657747968: Issue 356 - Update devbuild in the Chrome Web Store (Closed)

Created:
April 19, 2014, 4:12 p.m. by Sebastian Noack
Modified:
April 22, 2014, 6:38 a.m.
Visibility:
Public.

Description

I could only partially test it, since I don't have access to our Chrome Web Store account. In order to setup the Web Store API follow intructions at https://developer.chrome.com/webstore/using_webstore_api#beforeyoubegin.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Addressed comments #

Patch Set 3 : Use Client ID for installed applications #

Patch Set 4 : Skip CRX header when uploading to CWS #

Total comments: 6

Patch Set 5 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -11 lines) Patch
M .sitescripts.example View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 2 3 4 5 chunks +53 lines, -11 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode438 sitescripts/extensions/bin/createNightlies.py:438: subprocess.check_call([ I use curl instead of urllib here, because ...
April 19, 2014, 4:15 p.m. (2014-04-19 16:15:34 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode433 sitescripts/extensions/bin/createNightlies.py:433: )) Check for error responses? http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode438 sitescripts/extensions/bin/createNightlies.py:438: subprocess.check_call([ On ...
April 20, 2014, 6:47 a.m. (2014-04-20 06:47:52 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode433 sitescripts/extensions/bin/createNightlies.py:433: )) On 2014/04/20 06:47:53, Wladimir Palant wrote: > Check ...
April 20, 2014, 4:03 p.m. (2014-04-20 16:03:08 UTC) #3
Sebastian Noack
On 2014/04/20 16:03:08, Sebastian Noack wrote: > http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py > File sitescripts/extensions/bin/createNightlies.py (right): > > http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode433 ...
April 20, 2014, 8:53 p.m. (2014-04-20 20:53:03 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/sitescripts/extensions/bin/createNightlies.py#newcode425 sitescripts/extensions/bin/createNightlies.py:425: offset += 8 + sum(struct.unpack('<II', file.read(8))) Please don't skip ...
April 21, 2014, 8:22 p.m. (2014-04-21 20:22:56 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/sitescripts/extensions/bin/createNightlies.py#newcode425 sitescripts/extensions/bin/createNightlies.py:425: offset += 8 + sum(struct.unpack('<II', file.read(8))) On 2014/04/21 20:22:56, ...
April 21, 2014, 8:46 p.m. (2014-04-21 20:46:36 UTC) #6
Wladimir Palant
April 22, 2014, 5:12 a.m. (2014-04-22 05:12:35 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld