Issue 356 - Update devbuild in the Chrome Web Store

I could only partially test it, since I don't have access to our Chrome Web Store account.

In order to setup the Web Store API follow intructions at https://developer.chrome.com/webstore/using_webstore_api#beforeyoubegin.

[Sebastian Noack, 2014-04-19 16:15:34]

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:438: subprocess.check_call([
I use curl instead of urllib here, because urllib doesn't support file uploads.

[Wladimir Palant, 2014-04-20 06:47:52]

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:433: ))
Check for error responses?

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:438: subprocess.check_call([
On 2014/04/19 16:15:34, Sebastian Noack wrote:
> I use curl instead of urllib here, because urllib doesn't support file
uploads.

We do file uploads with urllib in buildtools/localeTools.py - not pretty but
better than calling an external application.

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:446: ])
Here as well - please check for error responses, if something goes wrong we
should know.

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:495: if self.config.type ==
'chrome':
This step needs to be optional, only if the necessary config options are present
- it should be possible to test things locally without triggering an upload
every time.

[Sebastian Noack, 2014-04-20 16:03:08]

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:433: ))
On 2014/04/20 06:47:53, Wladimir Palant wrote:
> Check for error responses?

This API uses standard HTTP  error codes, which are automatically converted into
Python exceptions by urllib2.

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:438: subprocess.check_call([
On 2014/04/20 06:47:53, Wladimir Palant wrote:
> On 2014/04/19 16:15:34, Sebastian Noack wrote:
> > I use curl instead of urllib here, because urllib doesn't support file
> uploads.
> 
> We do file uploads with urllib in buildtools/localeTools.py - not pretty but
> better than calling an external application.

It was actually easier to use urllib2 as I thought, since the API doesn't
actually require a multipart request.

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:446: ])
On 2014/04/20 06:47:53, Wladimir Palant wrote:
> Here as well - please check for error responses, if something goes wrong we
> should know.

Done.

http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
sitescripts/extensions/bin/createNightlies.py:495: if self.config.type ==
'chrome':
On 2014/04/20 06:47:53, Wladimir Palant wrote:
> This step needs to be optional, only if the necessary config options are
present
> - it should be possible to test things locally without triggering an upload
> every time.

Done.

[Sebastian Noack, 2014-04-20 20:53:03]

On 2014/04/20 16:03:08, Sebastian Noack wrote:
>
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
> File sitescripts/extensions/bin/createNightlies.py (right):
> 
>
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
> sitescripts/extensions/bin/createNightlies.py:433: ))
> On 2014/04/20 06:47:53, Wladimir Palant wrote:
> > Check for error responses?
> 
> This API uses standard HTTP  error codes, which are automatically converted
into
> Python exceptions by urllib2.
> 
>
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
> sitescripts/extensions/bin/createNightlies.py:438: subprocess.check_call([
> On 2014/04/20 06:47:53, Wladimir Palant wrote:
> > On 2014/04/19 16:15:34, Sebastian Noack wrote:
> > > I use curl instead of urllib here, because urllib doesn't support file
> > uploads.
> > 
> > We do file uploads with urllib in buildtools/localeTools.py - not pretty but
> > better than calling an external application.
> 
> It was actually easier to use urllib2 as I thought, since the API doesn't
> actually require a multipart request.
> 
>
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
> sitescripts/extensions/bin/createNightlies.py:446: ])
> On 2014/04/20 06:47:53, Wladimir Palant wrote:
> > Here as well - please check for error responses, if something goes wrong we
> > should know.
> 
> Done.
> 
>
http://codereview.adblockplus.org/5092904657747968/diff/5629499534213120/site...
> sitescripts/extensions/bin/createNightlies.py:495: if self.config.type ==
> 'chrome':
> On 2014/04/20 06:47:53, Wladimir Palant wrote:
> > This step needs to be optional, only if the necessary config options are
> present
> > - it should be possible to test things locally without triggering an upload
> > every time.
> 
> Done.

Apparently the Chrome Web Store API doesn't support service accounts. The Google
Account that owns the extension in the Web Store must approve access. It doesn't
matter if the Google Account that obtained the Client ID via the developer
console is the same. So we have to use a Client ID for installed applications
instead.

[Wladimir Palant, 2014-04-21 20:22:56]

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
sitescripts/extensions/bin/createNightlies.py:425: offset += 8 +
sum(struct.unpack('<II', file.read(8)))
Please don't skip magic number and version - read them to verify that they are
what you expect, otherwise you should raise an exception (particularly important
if CRX version changes).

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
sitescripts/extensions/bin/createNightlies.py:426: file.seek(offset)
Please use os.SEEK_CUR as second parameter to file.seek(), then you won't need a
complicated offset calculation - just a sum of the two lengths. For
Content-Length below you can use file.tell().

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
sitescripts/extensions/bin/createNightlies.py:483: if self.config.clientID and
self.config.clientSecret and self.config.refreshToken:
I think it makes sense to keep the type == 'chrome' check - it makes no sense to
attempt CWS upload for non-Chrome extensions, even if the necessary parameters
are configured. Note that these parameters aren't explicitly CWS-related, we
might theoretically decide to use the same set of parameters with other
extension stores (unlikely of course).

[Sebastian Noack, 2014-04-21 20:46:36]

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
File sitescripts/extensions/bin/createNightlies.py (right):

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
sitescripts/extensions/bin/createNightlies.py:425: offset += 8 +
sum(struct.unpack('<II', file.read(8)))
On 2014/04/21 20:22:56, Wladimir Palant wrote:
> Please don't skip magic number and version - read them to verify that they are
> what you expect, otherwise you should raise an exception (particularly
important
> if CRX version changes).

Done.

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
sitescripts/extensions/bin/createNightlies.py:426: file.seek(offset)
On 2014/04/21 20:22:56, Wladimir Palant wrote:
> Please use os.SEEK_CUR as second parameter to file.seek(), then you won't need
a
> complicated offset calculation - just a sum of the two lengths. For
> Content-Length below you can use file.tell().

Done.

http://codereview.adblockplus.org/5092904657747968/diff/5673385510043648/site...
sitescripts/extensions/bin/createNightlies.py:483: if self.config.clientID and
self.config.clientSecret and self.config.refreshToken:
On 2014/04/21 20:22:56, Wladimir Palant wrote:
> I think it makes sense to keep the type == 'chrome' check - it makes no sense
to
> attempt CWS upload for non-Chrome extensions, even if the necessary parameters
> are configured. Note that these parameters aren't explicitly CWS-related, we
> might theoretically decide to use the same set of parameters with other
> extension stores (unlikely of course).

Done.

[Wladimir Palant, 2014-04-22 05:12:35]

LGTM