Issue 332 - Add country flags to team page

Issue 332 - Add country flags to team page

[Thomas Greiner, 2014-04-29 16:38:50]

In the future we might want to add one single sprite image for all images on the
team page to reduce the number of requests. However, I think this should be
handled in a separate issue.

I also added a REAME.md for instructions on how to add additional flags. Let me
know if you prefer it to be in the root directory instead.

[Wladimir Palant, 2014-04-29 18:19:52]

http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
File pages/team.tmpl (right):

http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
pages/team.tmpl:32: <!-- Flag icons: Copyright (c) 2013 Go Squared Ltd.
http://www.gosquared.com/ -->
"The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software." - I don't think that this line
complies to their license. Aren't there any public domain flag icons where we
don't have licensing headaches?

[Thomas Greiner, 2014-04-30 14:13:59]

http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
File pages/team.tmpl (right):

http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
pages/team.tmpl:32: <!-- Flag icons: Copyright (c) 2013 Go Squared Ltd.
http://www.gosquared.com/ -->
On 2014/04/29 18:19:53, Wladimir Palant wrote:
> "The above copyright notice and this permission notice shall be included in
all
> copies or substantial portions of the Software." - I don't think that this
line
> complies to their license. Aren't there any public domain flag icons where we
> don't have licensing headaches?

This addition was approved by Kai beforehand although he doesn't consider it
absolutely necessary. It definitely doesn't hurt to have it in there but I can
ask the icon creators for clarification on that to make sure.

After putting more time into searching for alternatives, I was not able to find
flags that fit into the flat-design scheme of our page without looking cheap
while not requiring backlinks or payment.

[Wladimir Palant, 2014-04-30 14:17:48]

Oh well, LGTM

[Felix Dahlke, 2014-04-30 15:04:31]

LGTM, feel free to change the license notice to fully comply with the terms, but
I guess we're fine if Kai specifically OKd this.

http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
File pages/team.tmpl (right):

http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
pages/team.tmpl:32: <!-- Flag icons: Copyright (c) 2013 Go Squared Ltd.
http://www.gosquared.com/ -->
On 2014/04/30 14:13:59, Thomas Greiner wrote:
> On 2014/04/29 18:19:53, Wladimir Palant wrote:
> > "The above copyright notice and this permission notice shall be included in
> all
> > copies or substantial portions of the Software." - I don't think that this
> line
> > complies to their license. Aren't there any public domain flag icons where
we
> > don't have licensing headaches?
> 
> This addition was approved by Kai beforehand although he doesn't consider it
> absolutely necessary. It definitely doesn't hurt to have it in there but I can
> ask the icon creators for clarification on that to make sure.
> 
> After putting more time into searching for alternatives, I was not able to
find
> flags that fit into the flat-design scheme of our page without looking cheap
> while not requiring backlinks or payment.

Why not just do what they ask for and include the permission notice? Doesn't
seem like something we need to involve a lawyer over. But if Kai already said he
thinks it's fine...

[Thomas Greiner, 2014-05-02 09:46:35]

On 2014/04/30 15:04:31, Felix H. Dahlke wrote:
> LGTM, feel free to change the license notice to fully comply with the terms,
but
> I guess we're fine if Kai specifically OKd this.
> 
>
http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
> File pages/team.tmpl (right):
> 
>
http://codereview.adblockplus.org/5097747367591936/diff/5629499534213120/page...
> pages/team.tmpl:32: <!-- Flag icons: Copyright (c) 2013 Go Squared Ltd.
> http://www.gosquared.com/ -->
> On 2014/04/30 14:13:59, Thomas Greiner wrote:
> > On 2014/04/29 18:19:53, Wladimir Palant wrote:
> > > "The above copyright notice and this permission notice shall be included
in
> > all
> > > copies or substantial portions of the Software." - I don't think that this
> > line
> > > complies to their license. Aren't there any public domain flag icons where
> we
> > > don't have licensing headaches?
> > 
> > This addition was approved by Kai beforehand although he doesn't consider it
> > absolutely necessary. It definitely doesn't hurt to have it in there but I
can
> > ask the icon creators for clarification on that to make sure.
> > 
> > After putting more time into searching for alternatives, I was not able to
> find
> > flags that fit into the flat-design scheme of our page without looking cheap
> > while not requiring backlinks or payment.
> 
> Why not just do what they ask for and include the permission notice? Doesn't
> seem like something we need to involve a lawyer over. But if Kai already said
he
> thinks it's fine...

FYI: I received the response from the icons' creators. Their only concern is
that someone might redistribute the icons or claim ownership so we are fine.
They say that the license was not meant for the icons but for the buildtools in
https://github.com/gosquared/flags.

Generally, we don't need to include anything but they would appreciate some sort
of attribution so I'll keep that copyright notice in there.