Issue 412 - Make sure release automation creates Safari builds

build.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus build tools,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 477 matching lines @@
   command.addOption('Suppress JsDoc Toolkit output', short='q', long='quiet')
   command.params = '[options] <directory>'
   command.supportedTypes = ('gecko')
 
 with addCommand(runReleaseAutomation, 'release') as command:
   command.shortDescription = 'Run release automation'
   command.description = 'Note: If you are not the project owner then you '\
     'probably don\'t want to run this!\n\n'\
     'Runs release automation: creates downloads for the new version, tags '\
     'source code repository as well as downloads and buildtools repository.'
-  command.addOption('File containing private key and certificates required to sign the release. Note that for Chrome releases this option needs to be specified twice: one key to sign Chrome builds and another to sign the Safari build.', short='k', long='key', value='file', types=('gecko', 'chrome'))

[Sebastian Noack, 2014/05/02 08:29:09]

You should explicitly mention that the key for Chrome/Opera must be specified
first and the key for Safari must be specified last.

But I wonder whether it wouldn't be more intuitive and flexible to have to call
"build.py -t safari release" to generate a Safari release build?

[Wladimir Palant, 2014/05/02 10:50:50]

Done.
As discussed on IRC, splitting the release into multiple commands increases the
likelihood of issues considerably. Ideally the same command would even upload
the builds to the respective extension stores.

[Sebastian Noack, 2014/05/02 10:54:15]

Shouldn'T be a big deal for Chrome, since we have already implemented it for the
devbuild. Feel free to file an issue.

+  command.addOption('File containing private key and certificates required to sign the release. Note that for Chrome releases this option needs to be specified twice: first a key to sign Chrome/Opera builds, then another to sign the Safari build.', short='k', long='key', value='file', types=('gecko', 'chrome'))
   command.addOption('Directory containing downloads repository (if omitted ../downloads is assumed)', short='d', long='downloads', value='dir')
   command.params = '[options] <version>'
   command.supportedTypes = ('gecko', 'chrome')
 
 with addCommand(updatePSL, 'updatepsl') as command:
   command.shortDescription = 'Updates Public Suffix List'
   command.description = 'Downloads Public Suffix List (see http://publicsuffix.org/) and generates lib/publicSuffixList.js from it.'
   command.supportedTypes = ('chrome', 'opera')
 
 def getType(baseDir, scriptName, args):
@@ skipping 60 matching lines @@
         if option in ('-h', '--help'):
           usage(scriptName, type, command)
           sys.exit()
       commands[command](baseDir, scriptName, opts, args, type)
     else:
       print 'Command %s is not supported for this application type' % command
       usage(scriptName, type)
   else:
     print 'Command %s is unrecognized' % command
     usage(scriptName, type)