Issue 412 - Make sure release automation creates Safari builds

Issue 412 - Make sure release automation creates Safari builds

[Sebastian Noack, 2014-05-02 08:29:09]

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/buil...
File build.py (right):

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/buil...
build.py:498: command.addOption('File containing private key and certificates
required to sign the release. Note that for Chrome releases this option needs to
be specified twice: one key to sign Chrome builds and another to sign the Safari
build.', short='k', long='key', value='file', types=('gecko', 'chrome'))
You should explicitly mention that the key for Chrome/Opera must be specified
first and the key for Safari must be specified last.

But I wonder whether it wouldn't be more intuitive and flexible to have to call
"build.py -t safari release" to generate a Safari release build?

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
File releaseAutomation.py (right):

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
releaseAutomation.py:59: keyFile = keyFiles[0] if len(keyFiles) else None
len() isn't needed here, since empty lists evaluate to false.

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
releaseAutomation.py:69: packager.createBuild(baseDir, type=type,
outFile=buildPath, releaseBuild=True, keyFile=keyFiles[0])
Why don't you handle missing keyFiles here, but for Gecko?

[Wladimir Palant, 2014-05-02 10:50:50]

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/buil...
File build.py (right):

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/buil...
build.py:498: command.addOption('File containing private key and certificates
required to sign the release. Note that for Chrome releases this option needs to
be specified twice: one key to sign Chrome builds and another to sign the Safari
build.', short='k', long='key', value='file', types=('gecko', 'chrome'))
On 2014/05/02 08:29:09, Sebastian Noack wrote:
> You should explicitly mention that the key for Chrome/Opera must be specified
> first and the key for Safari must be specified last.

Done.

> But I wonder whether it wouldn't be more intuitive and flexible to have to
call
> "build.py -t safari release" to generate a Safari release build?

As discussed on IRC, splitting the release into multiple commands increases the
likelihood of issues considerably. Ideally the same command would even upload
the builds to the respective extension stores.

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
File releaseAutomation.py (right):

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
releaseAutomation.py:69: packager.createBuild(baseDir, type=type,
outFile=buildPath, releaseBuild=True, keyFile=keyFiles[0])
On 2014/05/02 08:29:09, Sebastian Noack wrote:
> Why don't you handle missing keyFiles here, but for Gecko?

An unsigned release for Gecko is an option and we actually produced unsigned
releases for a while due to Gecko bugs. Unsigned Chromium or Safari release on
the other hand isn't possible - builds always have to be signed.

[Sebastian Noack, 2014-05-02 10:54:15]

LGTM

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/buil...
File build.py (right):

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/buil...
build.py:498: command.addOption('File containing private key and certificates
required to sign the release. Note that for Chrome releases this option needs to
be specified twice: one key to sign Chrome builds and another to sign the Safari
build.', short='k', long='key', value='file', types=('gecko', 'chrome'))
On 2014/05/02 10:50:50, Wladimir Palant wrote:
> Ideally the same command would even upload
> the builds to the respective extension stores.

Shouldn'T be a big deal for Chrome, since we have already implemented it for the
devbuild. Feel free to file an issue.

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
File releaseAutomation.py (right):

http://codereview.adblockplus.org/5108575248580608/diff/5629499534213120/rele...
releaseAutomation.py:69: packager.createBuild(baseDir, type=type,
outFile=buildPath, releaseBuild=True, keyFile=keyFiles[0])
On 2014/05/02 10:50:50, Wladimir Palant wrote:
> On 2014/05/02 08:29:09, Sebastian Noack wrote:
> > Why don't you handle missing keyFiles here, but for Gecko?
> 
> An unsigned release for Gecko is an option and we actually produced unsigned
> releases for a while due to Gecko bugs. Unsigned Chromium or Safari release on
> the other hand isn't possible - builds always have to be signed.

Agreed.