Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5109546699718656: Improved implementation of loading event on Safari (Closed)

Created:
Dec. 20, 2013, 9:44 a.m. by Sebastian Noack
Modified:
Jan. 15, 2014, 4:19 p.m.
Visibility:
Public.

Description

Check for top level frame in content script, instead of comparing frame and tab URL in background page, for the loading event on Safari.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M safari/ext/background.js View 1 chunk +1 line, -1 line 0 comments Download
M safari/ext/content.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Dec. 20, 2013, 9:46 a.m. (2013-12-20 09:46:25 UTC) #1
Wladimir Palant
Jan. 15, 2014, 3:50 p.m. (2014-01-15 15:50:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld