Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5117069997637632: Issue 1548 - manually disable usage of v8_random_seed in gyp (Closed)

Created:
June 11, 2015, 12:59 p.m. by sergei
Modified:
July 5, 2017, 10:54 a.m.
CC:
Felix Dahlke
Visibility:
Public.

Description

Otherwise the generated project contains in the custom action "--random-seed" "..\..\..\..\..\..\third_party\v8\tools\gyp\314159265" instead of "--random-seed" "314159265" but the relative path should not be added

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
sergei
June 11, 2015, 1:25 p.m. (2015-06-11 13:25:07 UTC) #1
Eric
#1548 is now closed. Is this review still relevant?
Jan. 7, 2016, 4:30 p.m. (2016-01-07 16:30:21 UTC) #2
sergei
On 2016/01/07 16:30:21, Eric wrote: > #1548 is now closed. Is this review still relevant? ...
Jan. 21, 2016, 9:29 p.m. (2016-01-21 21:29:30 UTC) #3
Oleksandr
LGTM
Jan. 25, 2016, 2:19 p.m. (2016-01-25 14:19:24 UTC) #4
Eric
Jan. 26, 2016, 6:06 p.m. (2016-01-26 18:06:41 UTC) #5
On 2016/01/21 21:29:30, sergei wrote:
> On 2016/01/07 16:30:21, Eric wrote:
> > #1548 is now closed. Is this review still relevant?
> 
> Yes, it's still relevant.

OK. But should have mentioned that you reopened the issue here.

LGTM.

Powered by Google App Engine
This is Rietveld