Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5121479175831552: issue 47 - use WeakMap instead of setUserData and getUserData methods (Closed)

Created:
May 18, 2014, 12:48 p.m. by saroyanm
Modified:
May 18, 2014, 5:02 p.m.
Reviewers:
Wladimir Palant
CC:
arthur
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/47#comment:16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M lib/requestNotifier.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2
saroyanm
Wladimir please have a look on the patch, I've tested with FF nightly (32.0a1), with ...
May 18, 2014, 12:52 p.m. (2014-05-18 12:52:12 UTC) #1
Wladimir Palant
May 18, 2014, 4:30 p.m. (2014-05-18 16:30:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld