Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5133183649579008: Fixed: Popup blocking functionality broken (Closed)

Created:
Dec. 20, 2013, 3:08 p.m. by Thomas Greiner
Modified:
Jan. 13, 2014, 2:54 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Popup blocking has been broken since the introduction of ext.* See https://adblockplus.org/forum/viewtopic.php?f=11&t=19990

Patch Set 1 #

Patch Set 2 : Removed ext.webNavigation implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M popupBlocker.js View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Dec. 20, 2013, 3:11 p.m. (2013-12-20 15:11:08 UTC) #1
Wladimir Palant
I'm not sure whether this API makes sense. We definitely shouldn't do that for a ...
Dec. 20, 2013, 3:34 p.m. (2013-12-20 15:34:34 UTC) #2
Thomas Greiner
True, for now we can use Tab to keep it simple.
Dec. 20, 2013, 4:25 p.m. (2013-12-20 16:25:08 UTC) #3
Wladimir Palant
Jan. 13, 2014, 12:40 p.m. (2014-01-13 12:40:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld