Issue 5143068516810752: Added new stats server and user counter page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5143068516810752: Added new stats server and user counter page (Closed)

Created:
Dec. 20, 2013, 11:05 a.m. by Wladimir Palant

Modified:
Jan. 31, 2014, 2:25 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Added new stats server and user counter page

Patch Set 1 #

Patch Set 2 : Centralized stats processing #

Total comments: 1

Created: Dec. 20, 2013, 3:47 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -93 lines)			Patch
M	Vagrantfile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	manifests/downloadserver.pp	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download
M	manifests/filterserver.pp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	manifests/monitoringserver.pp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	manifests/notificationserver.pp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	manifests/statsserver.pp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	manifests/updateserver.pp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	manifests/vagrant.pp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	modules/downloadserver/manifests/init.pp	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	modules/filterserver/manifests/init.pp	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	modules/notificationserver/manifests/init.pp	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
R	modules/statsclient/files/sitescripts.ini	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	modules/statsclient/manifests/init.pp	View	1	2 chunks	+3 lines, -48 lines	0 comments	Download
M	modules/statsmaster/files/cron_geoipdb_update.sh	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	modules/statsmaster/files/sitescripts.ini	View	1	1 chunk	+20 lines, -17 lines	0 comments	Download
A	modules/statsmaster/files/usercounts.html	View		1 chunk	+256 lines, -0 lines	0 comments	Download
M	modules/statsmaster/manifests/init.pp	View	1	3 chunks	+29 lines, -5 lines	0 comments	Download
M	modules/updateserver/manifests/init.pp	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM with a nit. I would prefer to calculate the user numbers on the server ...

Jan. 31, 2014, 1:25 p.m. (2014-01-31 13:25:56 UTC) #2

Wladimir Palant

Jan. 31, 2014, 2:25 p.m. (2014-01-31 14:25:37 UTC) #3

The nit has been addressed under
https://hg.adblockplus.org/infrastructure/rev/400b611d281a. Calculating numbers
on the server is a possibility of course, didn't really feel like doing it when
this was implemented.

Expand All Messages | Collapse All Messages