Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(409)

Issue 5160622694072320: Issue 1133 - Fixed Twitter and Google+ buttons on first-run page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Thomas Greiner
Modified:
5 years, 5 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Fanboy's Social blocking list no longer blocks the Twitter and Google+ resources which we are checking for to determine whether to show the share overlay or not. For Twitter I changed the path accordingly but for Google+ I had to choose a different script since only element hiding filters were active in the share frame because I think they're too volatile for this purpose.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/content/ui/firstRun.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Thomas Greiner
5 years, 5 months ago (2014-09-08 08:57:13 UTC) #1
Wladimir Palant
5 years, 5 months ago (2014-09-10 21:19:12 UTC) #2
LGTM

If this happens again we should seriously reconsider the approach here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5