Issue 5160622694072320: Issue 1133 - Fixed Twitter and Google+ buttons on first-run page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5160622694072320: Issue 1133 - Fixed Twitter and Google+ buttons on first-run page (Closed)

Created:
Sept. 8, 2014, 8:52 a.m. by Thomas Greiner

Modified:
Sept. 11, 2014, 8:41 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Fanboy's Social blocking list no longer blocks the Twitter and Google+ resources which we are checking for to determine whether to show the share overlay or not. For Twitter I changed the path accordingly but for Google+ I had to choose a different script since only element hiding filters were active in the share frame because I think they're too volatile for this purpose.

Patch Set 1 #

Created: Sept. 8, 2014, 8:52 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/content/ui/firstRun.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

Sept. 10, 2014, 9:19 p.m. (2014-09-10 21:19:12 UTC) #2

LGTM

If this happens again we should seriously reconsider the approach here.

Expand All Messages | Collapse All Messages