Issue 1768 - Pass value returned by ext.onMessage listeners to chrome.runtime.onMessage listener

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 236 matching lines @@
   /* Web requests */
 
   var framesOfTabs = {__proto__: null};
 
   ext.getFrame = function(tabId, frameId)
   {
     return (framesOfTabs[tabId] || {})[frameId];
   };
 
   ext.webRequest = {
-    onBeforeRequest: new ext._EventTarget(true),
+    onBeforeRequest: new ext._EventTarget(),

[Sebastian Noack, 2015/01/09 10:58:25]

Beside passing the return value below, I also forgot to remove the argument to
_EventTarget() which isn't supported anymore.

     handlerBehaviorChanged: chrome.webRequest.handlerBehaviorChanged
   };
 
   chrome.tabs.query({}, function(tabs)
   {
     tabs.forEach(function(tab)
     {
       chrome.webNavigation.getAllFrames({tabId: tab.id}, function(details)
       {
         if (details && details.length > 0)
@@ skipping 117 matching lines @@
               if (frames[frameId].url == rawSender.url)
                 return frames[frameId].parent;
             }
           }
 
           return frames[0];
         }
       }
     };
 
-    return ext.onMessage._dispatch(message, sender, sendResponse);
+    return ext.onMessage._dispatch(message, sender, sendResponse).indexOf(true) != -1;
   });
 
 
   /* Storage */
 
   ext.storage = localStorage;
 
 
   /* Options */
 
@@ skipping 23 matching lines @@
             callback(new Page(tab));
         }
         else
         {
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
 })();