Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5162273421131776: Issue 1768 - Pass value returned by ext.onMessage listeners to chrome.runtime.onMessage listener (Closed)

Created:
Jan. 9, 2015, 10:56 a.m. by Sebastian Noack
Modified:
Jan. 9, 2015, 12:41 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1768 - Pass value returned by ext.onMessage listeners to chrome.runtime.onMessage listener

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/ext/background.js View 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/ext/content.js View 1 chunk +1 line, -1 line 0 comments Download
M safari/ext/background.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
http://codereview.adblockplus.org/5162273421131776/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/5162273421131776/diff/5629499534213120/chrome/ext/background.js#newcode257 chrome/ext/background.js:257: onBeforeRequest: new ext._EventTarget(), Beside passing the return value below, ...
Jan. 9, 2015, 10:58 a.m. (2015-01-09 10:58:25 UTC) #1
Wladimir Palant
Jan. 9, 2015, 12:29 p.m. (2015-01-09 12:29:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld