Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include.preload.js

Issue 5171381998190592: Issue 450 - Create shadow root immediatelly instead inside the reponse callback (Closed)
Left Patch Set: Created May 14, 2014, 2:26 p.m.
Right Patch Set: Addressed comment Created May 14, 2014, 2:59 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 var SELECTOR_GROUP_SIZE = 20; 18 var SELECTOR_GROUP_SIZE = 20;
19 19
20 // use Shadow DOM if available to don't mess with web pages that 20 // use Shadow DOM if available to don't mess with web pages that
21 // rely on the order of their own <style> tags. However 21 // rely on the order of their own <style> tags. However
22 // the <shadow> element is broken in some Chrome 32 builds (#309) 22 // the <shadow> element is broken in some Chrome 32 builds (#309)
23 // 23 //
24 // also we must not create the shadow root in the response callback passed 24 // also we must not create the shadow root in the response callback passed
25 // to sendMessage(), otherwise Chrome breaks some websites (#450) 25 // to sendMessage(), otherwise Chrome breaks some websites (#450)
26 var shadow = null; 26 var shadow = null;
27 if ("webkitCreateShadowRoot" in document.documentElement && !/\bChrome\/32\b/.te st(navigator.userAgent)) 27 if ("webkitCreateShadowRoot" in document.documentElement && !/\bChrome\/32\b/.te st(navigator.userAgent))
28 { 28 {
29 var shadow = document.documentElement.webkitCreateShadowRoot(); 29 shadow = document.documentElement.webkitCreateShadowRoot();
Wladimir Palant 2014/05/14 14:54:57 Please remove |var| here, you already declared the
Sebastian Noack 2014/05/14 14:59:59 Done.
30 shadow.appendChild(document.createElement("shadow")); 30 shadow.appendChild(document.createElement("shadow"));
31 } 31 }
32 32
33 // Sets the currently used CSS rules for elemhide filters 33 // Sets the currently used CSS rules for elemhide filters
34 function setElemhideCSSRules(selectors) 34 function setElemhideCSSRules(selectors)
35 { 35 {
36 if (selectors.length == 0) 36 if (selectors.length == 0)
37 return; 37 return;
38 38
39 var style = document.createElement("style"); 39 var style = document.createElement("style");
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 ext.backgroundPage.sendMessage({type: "add-key-exception", token: attr}); 130 ext.backgroundPage.sendMessage({type: "add-key-exception", token: attr});
131 131
132 ext.backgroundPage.sendMessage({type: "get-selectors"}, setElemhideCSSRules); 132 ext.backgroundPage.sendMessage({type: "get-selectors"}, setElemhideCSSRules);
133 } 133 }
134 134
135 // In Chrome 18 the document might not be initialized yet 135 // In Chrome 18 the document might not be initialized yet
136 if (document.documentElement) 136 if (document.documentElement)
137 init(); 137 init();
138 else 138 else
139 window.setTimeout(init, 0); 139 window.setTimeout(init, 0);
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld