Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5171381998190592: Issue 450 - Create shadow root immediatelly instead inside the reponse callback (Closed)

Created:
May 14, 2014, 2:26 p.m. by Sebastian Noack
Modified:
May 14, 2014, 2:59 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 450 - Create shadow root immediatelly instead inside the reponse callback

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M include.preload.js View 1 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
May 14, 2014, 2:28 p.m. (2014-05-14 14:28:57 UTC) #1
Wladimir Palant
LGTM with the issue fixed. Not a great solution but I guess we have to ...
May 14, 2014, 2:54 p.m. (2014-05-14 14:54:56 UTC) #2
Sebastian Noack
May 14, 2014, 2:59 p.m. (2014-05-14 14:59:59 UTC) #3
http://codereview.adblockplus.org/5171381998190592/diff/5629499534213120/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5171381998190592/diff/5629499534213120/incl...
include.preload.js:29: var shadow =
document.documentElement.webkitCreateShadowRoot();
On 2014/05/14 14:54:57, Wladimir Palant wrote:
> Please remove |var| here, you already declared the variable.

Done.

Powered by Google App Engine
This is Rietveld