Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5171847423328256: Change the way XML HTTP Requests are blocked (Closed)

Created:
July 1, 2014, 12:19 p.m. by Oleksandr
Modified:
July 1, 2014, 12:45 p.m.
Reviewers:
Felix Dahlke, Eric
Visibility:
Public.

Description

Change the way XML HTTP Requests are blocked

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +7 lines, -5 lines 1 comment Download

Messages

Total messages: 2
Oleksandr
Fixes the issue https://issues.adblockplus.org/ticket/714
July 1, 2014, 12:19 p.m. (2014-07-01 12:19:49 UTC) #1
Felix Dahlke
July 1, 2014, 12:22 p.m. (2014-07-01 12:22:51 UTC) #2
LGTM with a nit

http://codereview.adblockplus.org/5171847423328256/diff/5629499534213120/src/...
File src/plugin/PluginWbPassThrough.cpp (right):

http://codereview.adblockplus.org/5171847423328256/diff/5629499534213120/src/...
src/plugin/PluginWbPassThrough.cpp:273: if (((contentType ==
CFilter::contentTypeXmlHttpRequest)) && (isBlocked))
Redundant parentheses.

Powered by Google App Engine
This is Rietveld