Issue 5173617369284608: Issue 1868 - Handle <area> element properly when selected with "Block element"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5173617369284608: Issue 1868 - Handle <area> element properly when selected with "Block element" (Closed)

Created:
Jan. 28, 2015, 10:08 a.m. by Sebastian Noack

Modified:
Feb. 10, 2015, 11:05 a.m.

Reviewers:
kzar

CC:
Wladimir Palant

Visibility:
Public.

Description

Injecting overlays for images only work when using "Block element" from the icon popup, however not when using the context menu. No overlays are injected yet, when the context menu is used. Therefore we have to traverse the tree to find the image associated with the <area> element.

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Rebased and fixed grammar in comment #

Created: Feb. 10, 2015, 10:12 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -10 lines)			Patch
	M	include.postload.js	View	1	3 chunks	+40 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

http://codereview.adblockplus.org/5173617369284608/diff/5757334940811264/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5173617369284608/diff/5757334940811264/include.postload.js#newcode337 include.postload.js:337: // Add overlays for blockable elements that don't emit ...

Feb. 9, 2015, 5:24 p.m. (2015-02-09 17:24:40 UTC) #2

Sebastian Noack

Feb. 10, 2015, 10:19 a.m. (2015-02-10 10:19:27 UTC) #3

kzar

Feb. 10, 2015, 11:03 a.m. (2015-02-10 11:03:00 UTC) #4

LGTM

http://codereview.adblockplus.org/5173617369284608/diff/5757334940811264/incl...
File include.postload.js (right):

http://codereview.adblockplus.org/5173617369284608/diff/5757334940811264/incl...
include.postload.js:424: var usemap = image.getAttribute("usemap");
On 2015/02/10 10:19:27, Sebastian Noack wrote:
> On 2015/02/09 17:24:41, kzar wrote:
> > Don't we need to check that usemap isn't null before we try to use its
indexOf
> > and substr methods?
> 
> Mind the CSS selector above, excluding elements without "usemap" attribute.

Ah OK

Expand All Messages | Collapse All Messages