Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5181440375390208: Issue 298 - Switched to a more current SpiderMonkey build (Closed)

Created:
April 15, 2014, 8:07 a.m. by Wladimir Palant
Modified:
April 15, 2014, 9:21 p.m.
Reviewers:
tschuster
Visibility:
Public.

Description

Issue 298 - Switched to a more current SpiderMonkey build

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
April 15, 2014, 8:07 a.m. (2014-04-15 08:07:02 UTC) #1
tschuster
On 2014/04/15 08:07:02, Wladimir Palant wrote: I believe https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/ would be better. This one should ...
April 15, 2014, 5:29 p.m. (2014-04-15 17:29:45 UTC) #2
Wladimir Palant
On 2014/04/15 17:29:45, tschuster wrote: > I believe > https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/ > would be better. This ...
April 15, 2014, 8:50 p.m. (2014-04-15 20:50:25 UTC) #3
tschuster
April 15, 2014, 9:13 p.m. (2014-04-15 21:13:17 UTC) #4
On 2014/04/15 20:50:25, Wladimir Palant wrote:
> On 2014/04/15 17:29:45, tschuster wrote:
> > I believe
> >
https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/
> > would be better. This one should probably stay alive until ESR31, which is
> also
> > the time when we want to update again.
> 
> As I said in the issue, we shouldn't use latest-* - we would have people use a
> random and untested SpiderMonkey build. IMHO that's too risky, even for the
ESR
> branch. We should only use builds that we tested explicitly and confirmed that
> everything is working as expected.

I kind of doubt anything is going to break in ESR, but your concern is totally
reasonable.

LGTM

Powered by Google App Engine
This is Rietveld