Issue 5181440375390208: Issue 298 - Switched to a more current SpiderMonkey build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5181440375390208: Issue 298 - Switched to a more current SpiderMonkey build (Closed)

Created:
April 15, 2014, 8:07 a.m. by Wladimir Palant

Modified:
April 15, 2014, 9:21 p.m.

Reviewers:
tschuster

Visibility:
Public.

Description

Issue 298 - Switched to a more current SpiderMonkey build

Patch Set 1 #

Created: April 15, 2014, 8:07 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	utils.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

tschuster

On 2014/04/15 08:07:02, Wladimir Palant wrote: I believe https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/ would be better. This one should ...

April 15, 2014, 5:29 p.m. (2014-04-15 17:29:45 UTC) #2

Wladimir Palant

On 2014/04/15 17:29:45, tschuster wrote: > I believe > https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/ > would be better. This ...

April 15, 2014, 8:50 p.m. (2014-04-15 20:50:25 UTC) #3

tschuster

April 15, 2014, 9:13 p.m. (2014-04-15 21:13:17 UTC) #4

On 2014/04/15 20:50:25, Wladimir Palant wrote:
> On 2014/04/15 17:29:45, tschuster wrote:
> > I believe
> >
https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/
> > would be better. This one should probably stay alive until ESR31, which is
> also
> > the time when we want to update again.
> 
> As I said in the issue, we shouldn't use latest-* - we would have people use a
> random and untested SpiderMonkey build. IMHO that's too risky, even for the
ESR
> branch. We should only use builds that we tested explicitly and confirmed that
> everything is working as expected.

I kind of doubt anything is going to break in ESR, but your concern is totally
reasonable.

LGTM

Expand All Messages | Collapse All Messages