Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 5186743326212096: Issue 1843 - Deactivate "Block element" dialog when extension is disabled/uninstalled/reloaded (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by Sebastian Noack
Modified:
5 years ago
Reviewers:
kzar
CC:
Thomas Greiner, Wladimir Palant
Visibility:
Public.

Description

Issue 1843 - Deactivate "Block element" dialog when extension is disabled/uninstalled/reloaded

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-phrased comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M chrome/ext/background.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/ext/content.js View 1 chunk +30 lines, -0 lines 0 comments Download
M include.postload.js View 3 chunks +5 lines, -1 line 0 comments Download
M safari/ext/content.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
5 years ago (2015-01-23 09:48:39 UTC) #1
kzar
Nicely done, LGTM http://codereview.adblockplus.org/5186743326212096/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/5186743326212096/diff/5629499534213120/chrome/ext/background.js#newcode397 chrome/ext/background.js:397: chrome.runtime.onConnect.addListener(function() {}); The comment doesn't read ...
5 years ago (2015-01-26 16:05:22 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5186743326212096/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/5186743326212096/diff/5629499534213120/chrome/ext/background.js#newcode397 chrome/ext/background.js:397: chrome.runtime.onConnect.addListener(function() {}); On 2015/01/26 16:05:22, kzar wrote: > The ...
5 years ago (2015-01-26 16:13:55 UTC) #3
kzar
5 years ago (2015-01-26 16:14:58 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5