Quick-Fix in the context of #765 and #760

See https://issues.adblockplus.org/ticket/765 - first comment

[mathias, 2014-07-10 08:42:22]

Sorry, I've just realized that this is not enough yet. We do not only have to
ensure that the `ensure => absent` directive is run before Nagios starts, but
also that it's run after Nagios has been installed.. Update follows in a few
minutes.

[mathias, 2014-07-10 09:41:19]

See https://issues.adblockplus.org/ticket/765 - first comment

[Wladimir Palant, 2014-07-10 10:07:03]

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
File modules/nagios/manifests/server.pp (right):

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
modules/nagios/manifests/server.pp:95: before => Service['nagios3']
Are you sure we want these dependencies for the files we *remove*?

[mathias, 2014-07-10 10:22:17]

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
File modules/nagios/manifests/server.pp (right):

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
modules/nagios/manifests/server.pp:85: file
{['/etc/nagios3/conf.d/contacts_nagios2.cfg',
Another possible optimization here: We could probably perform the deletion based
on a pattern (e.g. *_nagios2.cfg). That way we won't be surprised some day, when
the maintainer of the package introduces new files or something like that (see
also my next comment). On the other hand we would then have to ensure that we
won't use a matching filename ourselves.

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
modules/nagios/manifests/server.pp:95: before => Service['nagios3']
On 2014/07/10 10:07:04, Wladimir Palant wrote:
> Are you sure we want these dependencies for the files we *remove*?

Almost sure.

As far as I can see these files are the defaults provided by the package
manager. Because they conflict with the ones puppet generates for us, they've
been removed in this directive (before my commit already). All I've tried to do
is a) ensure that this is done "early enough" - before the service is started
the first time - and b) "late enough" - after the package is installed.

I believe this issue existed for a while, but since execution order varies when
undefined the problem has gone unnoticed for a while.

[Wladimir Palant, 2014-07-10 10:38:20]

LGTM

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
File modules/nagios/manifests/server.pp (right):

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
modules/nagios/manifests/server.pp:85: file
{['/etc/nagios3/conf.d/contacts_nagios2.cfg',
On 2014/07/10 10:22:17, matze wrote:
> Another possible optimization here: We could probably perform the deletion
based
> on a pattern (e.g. *_nagios2.cfg).

I don't think Puppet allows pattern matches for file resources. We could use a
shell command instead but that's ugly (especially checking whether that command
needs to run). And we aren't guaranteed that new files added by the package
maintainer will still follow that naming scheme. So I'd be in favor of leaving
things as they are. Note that we are using an LTS Ubuntu release exactly in
order to avoid such issues, at least for a while.

http://codereview.adblockplus.org/5189767234846720/diff/5741031244955648/modu...
modules/nagios/manifests/server.pp:95: before => Service['nagios3']
On 2014/07/10 10:22:17, matze wrote:
> As far as I can see these files are the defaults provided by the package
> manager. Because they conflict with the ones puppet generates for us, they've
> been removed in this directive (before my commit already). All I've tried to
do
> is a) ensure that this is done "early enough" - before the service is started
> the first time - and b) "late enough" - after the package is installed.

Ok, I see now. So the issue was simply these files still being around when
Nagios started...