Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5192042284056576: Hide bubble when opening options page in Safari (Closed)

Created:
Dec. 23, 2013, 2:57 p.m. by Sebastian Noack
Modified:
Jan. 16, 2014, 11:40 a.m.
Visibility:
Public.

Description

Safari doesn't hide the bubble automatically, when we change the active tab programmatically, like when the options link is clicked. So I have added an event listener to the bubble, that hides the bubble when the active tab changes.

Patch Set 1 #

Patch Set 2 : Added missing bracket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M safari/ext/popup.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Dec. 23, 2013, 3:07 p.m. (2013-12-23 15:07:57 UTC) #1
Wladimir Palant
LGTM
Dec. 23, 2013, 5:02 p.m. (2013-12-23 17:02:09 UTC) #2
Sebastian Noack
Dec. 24, 2013, 10:49 a.m. (2013-12-24 10:49:18 UTC) #3
Wladimir Palant
Jan. 15, 2014, 3:47 p.m. (2014-01-15 15:47:54 UTC) #4
Still LGTM.

Powered by Google App Engine
This is Rietveld