Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5198903443980288: Issue 321 - libadblockplus build fails on OS X (tr1/memory.h not found) (Closed)

Created:
April 14, 2014, 11:24 a.m. by Wladimir Palant
Modified:
April 14, 2014, 3:52 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

OTHER_LDFLAGS should only be used for executables, libtool doesn`t support this parameter. Unfortunately, I couldn`t find a way to do this in common.gypi.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M shell/shell.gyp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
April 14, 2014, 11:24 a.m. (2014-04-14 11:24:51 UTC) #1
Felix Dahlke
April 14, 2014, 3:37 p.m. (2014-04-14 15:37:52 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld