background.js - Issue 5225119261655040: Issue 1282 - Don't generate filters conflicting with existing exception rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 5225119261655040: Issue 1282 - Don't generate filters conflicting with existing exception rules (Closed)

Patch Set: Rebased Created Feb. 28, 2015, 6:03 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -555,7 +555,8 @@

case "compose-filters":

sendResponse(composeFilters(

msg.tagName, msg.id, msg.src, msg.style,

- msg.classes, msg.urls, new URL(msg.baseURL)

+ msg.classes, msg.urls, msg.mediatype,

+ msg.baseURL, sender.page, sender.frame

Wladimir Palant 2015/03/02 20:14:19 Ten positional parameters in a function is certain

Sebastian Noack 2015/03/03 14:29:00 How about reducing the number of arguments by grou

Wladimir Palant 2015/03/03 14:40:31 That's eight parameters now - still way too many t

Sebastian Noack 2015/03/03 14:59:28 Fair enough.

));

break;

case "forward":

« no previous file with comments | « no previous file | include.postload.js » ('j') | include.postload.js » ('J')