Issue 5229474392047616: Issue 2582 - Optimize loop in ElemHide.getSelectorsForDomain() for V8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5229474392047616: Issue 2582 - Optimize loop in ElemHide.getSelectorsForDomain() for V8 (Closed)

Created:
May 24, 2015, 5:12 p.m. by Sebastian Noack

Modified:
June 3, 2015, 3:46 p.m.

Reviewers:
Thomas Greiner, Wladimir Palant

Visibility:
Public.

Description

Issue 2582 - Optimize loop in ElemHide.getSelectorsForDomain() for V8

Patch Set 1 #

Patch Set 2 : Use Object.getOwnPropertyNames() #

Created: June 3, 2015, 11:08 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	lib/elemHide.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Sebastian Noack

It turned out that Object.getOwnPropertyNames() is even faster. So here comes a new patch.

June 3, 2015, 11:09 a.m. (2015-06-03 11:09:08 UTC) #4

Thomas Greiner

LGTM I would've prefered `Object.keys()` because `Object.getOwnPropertyNames()` also includes non-enumerable properties. In this specific case, ...

June 3, 2015, 2:13 p.m. (2015-06-03 14:13:38 UTC) #5

Sebastian Noack

June 3, 2015, 2:18 p.m. (2015-06-03 14:18:41 UTC) #6

On 2015/06/03 14:13:38, Thomas Greiner wrote:
> I would've prefered `Object.keys()` because `Object.getOwnPropertyNames()`
also
> includes non-enumerable properties. In this specific case, however, it should
be
> fine since we don't have any of those.

Well, if we weren't optimizing here I would just keep te for..in loop.

Expand All Messages | Collapse All Messages