Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5230369355857920: Issue 2432 - Ignore temporary issues when retrieving browser versions (Closed)

Created:
May 19, 2015, 1:49 p.m. by Sebastian Noack
Modified:
May 19, 2015, 2:22 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2432 - Ignore temporary issues when retrieving browser versions

Patch Set 1 #

Total comments: 5

Patch Set 2 : Don't round timestamp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M globals/get_browser_versions.py View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
May 19, 2015, 1:55 p.m. (2015-05-19 13:55:22 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py File globals/get_browser_versions.py (right): http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py#newcode184 globals/get_browser_versions.py:184: now = time.mktime(time.gmtime()) now = time.time()? http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py#newcode215 globals/get_browser_versions.py:215: versions['timestamp'] ...
May 19, 2015, 2:15 p.m. (2015-05-19 14:15:47 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py File globals/get_browser_versions.py (right): http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py#newcode184 globals/get_browser_versions.py:184: now = time.mktime(time.gmtime()) On 2015/05/19 14:15:47, Wladimir Palant wrote: ...
May 19, 2015, 2:18 p.m. (2015-05-19 14:18:22 UTC) #3
Wladimir Palant
May 19, 2015, 2:20 p.m. (2015-05-19 14:20:39 UTC) #4
LGTM, the remaining comment isn't important.

http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/glob...
File globals/get_browser_versions.py (right):

http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/glob...
globals/get_browser_versions.py:184: now = time.mktime(time.gmtime())
On 2015/05/19 14:18:22, Sebastian Noack wrote:
> This would return local time.

I don't really see a problem with that. Wouldn't even matter if our servers
switched to summer time (which they don't, using UTC consistently).

Powered by Google App Engine
This is Rietveld