Issue 5230369355857920: Issue 2432 - Ignore temporary issues when retrieving browser versions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5230369355857920: Issue 2432 - Ignore temporary issues when retrieving browser versions (Closed)

Created:
May 19, 2015, 1:49 p.m. by Sebastian Noack

Modified:
May 19, 2015, 2:22 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Issue 2432 - Ignore temporary issues when retrieving browser versions

Patch Set 2 : Don't round timestamp #

Created: May 19, 2015, 2:18 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	globals/get_browser_versions.py	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py File globals/get_browser_versions.py (right): http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py#newcode184 globals/get_browser_versions.py:184: now = time.mktime(time.gmtime()) now = time.time()? http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/globals/get_browser_versions.py#newcode215 globals/get_browser_versions.py:215: versions['timestamp'] ...

May 19, 2015, 2:15 p.m. (2015-05-19 14:15:47 UTC) #2

Sebastian Noack

May 19, 2015, 2:18 p.m. (2015-05-19 14:18:22 UTC) #3

Wladimir Palant

May 19, 2015, 2:20 p.m. (2015-05-19 14:20:39 UTC) #4

LGTM, the remaining comment isn't important.

http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/glob...
File globals/get_browser_versions.py (right):

http://codereview.adblockplus.org/5230369355857920/diff/5629499534213120/glob...
globals/get_browser_versions.py:184: now = time.mktime(time.gmtime())
On 2015/05/19 14:18:22, Sebastian Noack wrote:
> This would return local time.

I don't really see a problem with that. Wouldn't even matter if our servers
switched to summer time (which they don't, using UTC consistently).

Expand All Messages | Collapse All Messages