Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5281597276291072: Issue #1187 - Do not use MsiViewClose to close view handles (Closed)

Created:
Jan. 7, 2015, 10:23 p.m. by Eric
Modified:
Jan. 13, 2015, 3:03 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1187 - Do not use MsiViewClose to close view handles Contrary to all good naming sense, the API call MsiViewClose does not close the handle to a view. Instead, the regular MsiCloseHandle is used.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M installer/src/installer-lib/database.h View 1 chunk +1 line, -17 lines 0 comments Download

Messages

Total messages: 2
Eric
Jan. 7, 2015, 10:24 p.m. (2015-01-07 22:24:34 UTC) #1
Oleksandr
Jan. 13, 2015, 10:07 a.m. (2015-01-13 10:07:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld