Issue 2100 - Fixed block element dialog moving outside viewport

Issue 2100 - Fixed block element dialog moving outside viewport

[Sebastian Noack, 2015-03-09 14:56:55]

I've tested that patch, and while this change successfully prevents dragging the
dialog outside of the visible area, the visual feedback is kinda broken. I
temporarily see two dialogs, after attempting to drag the dialog out of the
window.

[Thomas Greiner, 2015-03-09 15:33:47]

On 2015/03/09 14:56:55, Sebastian Noack wrote:
> I've tested that patch, and while this change successfully prevents dragging
the
> dialog outside of the visible area, the visual feedback is kinda broken. I
> temporarily see two dialogs, after attempting to drag the dialog out of the
> window.

Yes, but that behavior has been there before. The issue is not that you see two
dialogs (one's our DOM element, the other one's created by the browser when
dragging an element) but that we're moving our element (using the "ondrag"
event) which makes it look very odd.

I didn't consider it to be part of this issue since it's not really related to
#2100. What I'm planning to do is create a separate issue to remove listening to
the "ondrag" event to fix this.

[Sebastian Noack, 2015-03-09 15:36:24]

On 2015/03/09 15:33:47, Thomas Greiner wrote:
> On 2015/03/09 14:56:55, Sebastian Noack wrote:
> > I've tested that patch, and while this change successfully prevents dragging
> the
> > dialog outside of the visible area, the visual feedback is kinda broken. I
> > temporarily see two dialogs, after attempting to drag the dialog out of the
> > window.
> 
> Yes, but that behavior has been there before. The issue is not that you see
two
> dialogs (one's our DOM element, the other one's created by the browser when
> dragging an element) but that we're moving our element (using the "ondrag"
> event) which makes it look very odd.
> 
> I didn't consider it to be part of this issue since it's not really related to
> #2100. What I'm planning to do is create a separate issue to remove listening
to
> the "ondrag" event to fix this.

Well, previously it wasn't visible, because our DOM element was in sync with the
overlay created by the browser. So I consider this a regression introduced by
your change, I'd like to see fixed before merging this. How about only moving
the dialog once the drag operation has been finished?

[Sebastian Noack, 2015-03-20 17:58:18]

LGTM. But please test it in Safari as well before pushing.