Issue 5316783485485056: Issue 670 - Use GeoIP City database for AWStats

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5316783485485056: Issue 670 - Use GeoIP City database for AWStats (Closed)

Created:
June 17, 2014, 3:06 p.m. by Wladimir Palant

Modified:
June 23, 2014, 7:30 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Issue 670 - Use GeoIP City database for AWStats

Patch Set 1 #

Total comments: 1

Created: June 17, 2014, 3:06 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -17 lines)			Patch
M	modules/statsmaster/files/cron_geoipdb_update.py	View	1 chunk	+15 lines, -13 lines	1 comment	Download
M	modules/statsmaster/manifests/init.pp	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	modules/statsmaster/templates/awstats.conf	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/5316783485485056/diff/5629499534213120/modules/statsmaster/files/cron_geoipdb_update.py File modules/statsmaster/files/cron_geoipdb_update.py (right): http://codereview.adblockplus.org/5316783485485056/diff/5629499534213120/modules/statsmaster/files/cron_geoipdb_update.py#newcode5 modules/statsmaster/files/cron_geoipdb_update.py:5: from StringIO import StringIO I already removed that import ...

June 17, 2014, 3:16 p.m. (2014-06-17 15:16:21 UTC) #2

LGTM

Expand All Messages | Collapse All Messages