Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5320026647166976: Issue 1381 - Element hiding exceptions broken after #432 landing (Closed)

Created:
Sept. 18, 2014, 12:10 p.m. by Wladimir Palant
Modified:
Sept. 18, 2014, 1:26 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 1381 - Element hiding exceptions broken after #432 landing

Patch Set 1 #

Total comments: 4

Patch Set 2 : More consistent approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/contentPolicy.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Sept. 18, 2014, 12:10 p.m. (2014-09-18 12:10:19 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/contentPolicy.js File lib/contentPolicy.js (right): http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/contentPolicy.js#newcode192 lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE ? false : ...
Sept. 18, 2014, 12:45 p.m. (2014-09-18 12:45:36 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/contentPolicy.js File lib/contentPolicy.js (right): http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/contentPolicy.js#newcode192 lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE ? false : ...
Sept. 18, 2014, 12:56 p.m. (2014-09-18 12:56:22 UTC) #3
Wladimir Palant
Uploaded a different solution, for other whitelisting rules we simply passed in false for the ...
Sept. 18, 2014, 1:04 p.m. (2014-09-18 13:04:46 UTC) #4
Thomas Greiner
LGTM. Both approaches are fine with me. http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/contentPolicy.js File lib/contentPolicy.js (right): http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/contentPolicy.js#newcode192 lib/contentPolicy.js:192: let thirdParty ...
Sept. 18, 2014, 1:15 p.m. (2014-09-18 13:15:10 UTC) #5
Wladimir Palant
Sept. 18, 2014, 1:26 p.m. (2014-09-18 13:26:16 UTC) #6
http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
File lib/contentPolicy.js (right):

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE
? false : isThirdParty(location, docDomain));
On 2014/09/18 13:15:10, Thomas Greiner wrote:
> Got it, I guess I relied to much on the browser search feature here which
can't
> deal with line breaks.

The browser search feature is fine, it's actually Rietveld's markup :) Try to
copy that text and you will see.

Powered by Google App Engine
This is Rietveld