Issue 1381 - Element hiding exceptions broken after #432 landing

Issue 1381 - Element hiding exceptions broken after #432 landing

[Thomas Greiner, 2014-09-18 12:45:36]

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
File lib/contentPolicy.js (right):

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE
? false : isThirdParty(location, docDomain));
I'm sure you tried it out but I don't see how moving it upwards in the same
block eliminates the error message "ReferenceError: can't access let declaration
'thirdParty' before initialization" or why this would be related to #432.

[Wladimir Palant, 2014-09-18 12:56:22]

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
File lib/contentPolicy.js (right):

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE
? false : isThirdParty(location, docDomain));
That variable is being accessed in line 227/228 below - that line executes
before the variable declaration.

You are right however, while #432 changed that code last this issue was present
earlier as well. I guess that Firefox simply got stricter about let variables.

[Wladimir Palant, 2014-09-18 13:04:46]

Uploaded a different solution, for other whitelisting rules we simply passed in
false for the thirdParty parameter - we should do the same here.

[Thomas Greiner, 2014-09-18 13:15:10]

LGTM. Both approaches are fine with me.

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
File lib/contentPolicy.js (right):

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE
? false : isThirdParty(location, docDomain));
Got it, I guess I relied to much on the browser search feature here which can't
deal with line breaks.

On 2014/09/18 12:56:22, Wladimir Palant wrote:
> That variable is being accessed in line 227/228 below - that line executes
> before the variable declaration.
> 
> You are right however, while #432 changed that code last this issue was
present
> earlier as well. I guess that Firefox simply got stricter about let variables.

[Wladimir Palant, 2014-09-18 13:26:16]

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
File lib/contentPolicy.js (right):

http://codereview.adblockplus.org/5320026647166976/diff/5629499534213120/lib/...
lib/contentPolicy.js:192: let thirdParty = (contentType == Policy.type.ELEMHIDE
? false : isThirdParty(location, docDomain));
On 2014/09/18 13:15:10, Thomas Greiner wrote:
> Got it, I guess I relied to much on the browser search feature here which
can't
> deal with line breaks.

The browser search feature is fine, it's actually Rietveld's markup :) Try to
copy that text and you will see.