lib/contentPolicy.js - Issue 5320026647166976: Issue 1381 - Element hiding exceptions broken after #432 landing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/contentPolicy.js

Issue 5320026647166976: Issue 1381 - Element hiding exceptions broken after #432 landing (Closed)

Patch Set: More consistent approach Created Sept. 18, 2014, 1:03 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/contentPolicy.js

===================================================================

--- a/lib/contentPolicy.js

+++ b/lib/contentPolicy.js

@@ -219,17 +219,17 @@ let Policy = exports.Policy =

if (!match.isActiveOnDomain(docDomain))

return true;

let exception = ElemHide.getException(match, docDomain);

if (exception)

{

FilterStorage.increaseHitCount(exception, wnd);

- RequestNotifier.addNodeData(node, topWnd, contentType, docDomain, thirdParty, locationText, exception);

+ RequestNotifier.addNodeData(node, topWnd, contentType, docDomain, false, locationText, exception);

return true;

}

let thirdParty = (contentType == Policy.type.ELEMHIDE ? false : isThirdParty(location, docDomain));

if (!match && Prefs.enabled)

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »