Populate AppInfo properly

src/org/adblockplus/android/ABPEngine.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 32 matching lines @@
     String version;
     try
     {
       final PackageInfo info = context.getPackageManager().getPackageInfo(context.getPackageName(), 0);
       version = info.versionName + "." + info.versionCode;
     } catch (NameNotFoundException e)
     {
       Log.e(TAG, "Failed to get the application version number", e);
       version = "0";
     }
-    final String applicationVersion = String.valueOf(VERSION.SDK_INT);

[Wladimir Palant, 2013/11/17 06:31:06]

Shouldn't this be called sdkVersion?

[Felix Dahlke, 2013/11/18 15:42:35]

Done.

+    final String sdkVersion = String.valueOf(VERSION.SDK_INT);
     final String locale = context.getResources().getConfiguration().locale.toString();
     final boolean developmentBuild = !context.getResources().getBoolean(R.bool.def_release);
-    initialize(basePath, version, applicationVersion, locale, developmentBuild);
+    initialize(basePath, version, sdkVersion, locale, developmentBuild);
   }
 
   public void onFilterChanged(String url, String status, long time)
   {
     context.sendBroadcast(new Intent(AdblockPlus.BROADCAST_SUBSCRIPTION_STATUS).putExtra("url", url).putExtra("status", status).putExtra("time", time));
   }
   
   /**
    * Called when update event occurred.
    * @param url Update download address
@@ skipping 65 matching lines @@
 
     Notification notification = builder.getNotification();
     return notification;
   }
 
   static
   {
     System.loadLibrary("abpEngine");
   }
 }