Issue 5336189238247424: Populate AppInfo properly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5336189238247424: Populate AppInfo properly (Closed)

Created:
Nov. 15, 2013, 1:39 p.m. by Felix Dahlke

Modified:
Nov. 18, 2013, 3:42 p.m.

Reviewers:
Andrey Novikov, Wladimir Palant

Visibility:
Public.

Description

With this, we're setting most AppInfo properties to the correct values. The one property we're not setting is "id", but it doesn't look like that's relevant here. While I was at it, I camel cased the basePath parameter and inlined the temporary variable for it.

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Renamed applicationVersion variable #

Created: Nov. 18, 2013, 3:41 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -11 lines)			Patch
	M	jni/abpEngine.cpp	View		3 chunks	+18 lines, -9 lines	0 comments	Download
	M	src/org/adblockplus/android/ABPEngine.java	View	1	3 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

LGTM with the nit fixed. http://codereview.adblockplus.org/5336189238247424/diff/5840605766746112/src/org/adblockplus/android/ABPEngine.java File src/org/adblockplus/android/ABPEngine.java (right): http://codereview.adblockplus.org/5336189238247424/diff/5840605766746112/src/org/adblockplus/android/ABPEngine.java#newcode53 src/org/adblockplus/android/ABPEngine.java:53: final String applicationVersion = ...

Nov. 17, 2013, 6:31 a.m. (2013-11-17 06:31:06 UTC) #2

Felix Dahlke

Nov. 18, 2013, 3:42 p.m. (2013-11-18 15:42:35 UTC) #3

Fixed and pushed:
https://hg.adblockplus.org/adblockplusandroid/rev/0cbe02ba4c55

http://codereview.adblockplus.org/5336189238247424/diff/5840605766746112/src/...
File src/org/adblockplus/android/ABPEngine.java (right):

http://codereview.adblockplus.org/5336189238247424/diff/5840605766746112/src/...
src/org/adblockplus/android/ABPEngine.java:53: final String applicationVersion =
String.valueOf(VERSION.SDK_INT);
On 2013/11/17 06:31:06, Wladimir Palant wrote:
> Shouldn't this be called sdkVersion?

Done.

Expand All Messages | Collapse All Messages