Issue 2628 - Fix stable version of Yandex.Browser listed on the requirements page

Issue 2628 - Fix stable version of Yandex.Browser listed on the requirements page

[Wladimir Palant, 2015-06-03 16:27:56]

I don't think that the current behavior (stable: manual is newer, beta: manual
is older) will not stay this way. At some point they might want to test a newer
beta via manual updates, or the manual stable update will become outdated. IMHO
there is no way around getting both and choosing whichever is newer.

[Sebastian Noack, 2015-06-03 16:37:45]

On 2015/06/03 16:27:56, Wladimir Palant wrote:
> I don't think that the current behavior (stable: manual is newer, beta: manual
> is older) will not stay this way. At some point they might want to test a
newer
> beta via manual updates, or the manual stable update will become outdated.
IMHO
> there is no way around getting both and choosing whichever is newer.

Good point. Done.

[Wladimir Palant, 2015-06-03 17:11:35]

http://codereview.adblockplus.org/5341722020151296/diff/5649050225344512/glob...
File globals/get_browser_versions.py (right):

http://codereview.adblockplus.org/5341722020151296/diff/5649050225344512/glob...
globals/get_browser_versions.py:135: response =
urllib.urlopen('https://api.browser.yandex.ru/update-info/browser/yandex%s/win-yandex.xml'
% (suffix, params))
If I'm not mistaken this should produce "not all arguments converted during
string formatting" - did you forget %s at the end of the string?

[Sebastian Noack, 2015-06-03 17:42:30]

http://codereview.adblockplus.org/5341722020151296/diff/5649050225344512/glob...
File globals/get_browser_versions.py (right):

http://codereview.adblockplus.org/5341722020151296/diff/5649050225344512/glob...
globals/get_browser_versions.py:135: response =
urllib.urlopen('https://api.browser.yandex.ru/update-info/browser/yandex%s/win-yandex.xml'
% (suffix, params))
On 2015/06/03 17:11:36, Wladimir Palant wrote:
> If I'm not mistaken this should produce "not all arguments converted during
> string formatting" - did you forget %s at the end of the string?

Argh, you are right. I did test the change, but in case of an error the version
is served from the cache. And with recent changes we don't even get a warning in
the console anymore when it succeeded within the past 2 hours.

[Wladimir Palant, 2015-06-03 19:25:14]

LGTM