Issue 5361415552499712: Issue 2145 - Strings from random locales show up on English pages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5361415552499712: Issue 2145 - Strings from random locales show up on English pages (Closed)

Created:
March 13, 2015, 8:56 p.m. by Wladimir Palant

Modified:
March 13, 2015, 9:27 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 2145 - Strings from random locales show up on English pages

Patch Set 1 #

Created: March 13, 2015, 8:56 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cms/sources.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sebastian Noack

LGTM. However I'd prefer to have commit/review titles phrased like what they change as opposed ...

March 13, 2015, 9:13 p.m. (2015-03-13 21:13:49 UTC) #2

Wladimir Palant

On 2015/03/13 21:13:49, Sebastian Noack wrote: > However I'd prefer to have commit/review titles phrased ...

March 13, 2015, 9:17 p.m. (2015-03-13 21:17:33 UTC) #3

Sebastian Noack

March 13, 2015, 9:27 p.m. (2015-03-13 21:27:07 UTC) #4

On 2015/03/13 21:17:33, Wladimir Palant wrote:
> On 2015/03/13 21:13:49, Sebastian Noack wrote:
> > However I'd prefer to have commit/review titles phrased like what they
> > change as opposed to describing the current situation.
> 
> Frankly, I disagree - the reasoning for a change is typically much more
> important than the actual contents.

I'm not suggesting to make the title less meaningful. I'm merely talking about
the phrasing. And strictly a change with a title like this sounds more like its
introducing that behavior rather than changing it. Just add a "Prevent" for
example and it makes much more sense.

Expand All Messages | Collapse All Messages