Issue 101 - Fix icon tests

This fixes the icon tests. I changed the tests so that we only test in newish Firefox version, which have CustomizableUI.jsm.

[Wladimir Palant, 2014-07-30 06:04:51]

If addressing my comment below is easy, please do so. Otherwise - LGTM.

http://codereview.adblockplus.org/5390879414026240/diff/5629499534213120/chro...
File chrome/content/tests/ui/icon_position.js (right):

http://codereview.adblockplus.org/5390879414026240/diff/5629499534213120/chro...
chrome/content/tests/ui/icon_position.js:14: return;
I wonder whether we can have a solution that works both with CustomizableUI as
well as with the backwards compatibility shim - the latter is being used with
SeaMonkey for example and is rather non-trivial (in fact, it's way more likely
to break than the variant using CustomizableUI). Maybe define a function to wrap
CustomizableUI.getPlacementOfWidget()?

The only complication is when we need to move the icon. But we could skip the
second test in this scenario rather than skipping all of them.

[tschuster, 2014-07-31 10:29:24]

I tested this with Firefox 24. I think Seamonkey should behave the same.

[Wladimir Palant, 2014-07-31 10:40:36]

http://codereview.adblockplus.org/5390879414026240/diff/5724160613416960/chro...
File chrome/content/tests/ui/icon_position.js (right):

http://codereview.adblockplus.org/5390879414026240/diff/5724160613416960/chro...
chrome/content/tests/ui/icon_position.js:37: const AREA_NAVBAR = usingShim ?
"PersonalToolbar" : CustomizableUI.AREA_NAVBAR;
Personal toolbar, seriously? I think this should be
require("appSupport").defaultToolbarPosition.parent (which is "nav-bar" in
Firefox).

In your case, the toolbar icon was likely moved to a non-default position.
Unlike the real CustomizableUI, our implementation remembers the icon position
even if the icon is hidden. I guess you need to remove the "abp-iconposition"
attribute from the toolbox manually.

http://codereview.adblockplus.org/5390879414026240/diff/5724160613416960/chro...
chrome/content/tests/ui/icon_position.js:60: ok(true, "Can not test");
Nit: this should be "Cannot"

[Wladimir Palant, 2014-07-31 11:36:14]

http://codereview.adblockplus.org/5390879414026240/diff/5657382461898752/chro...
File chrome/content/tests/ui/icon_position.js (right):

http://codereview.adblockplus.org/5390879414026240/diff/5657382461898752/chro...
chrome/content/tests/ui/icon_position.js:23: return;
This is only relevant when we are using the shim - otherwise we don't care
whether we can find the toolbox.

While at it, we probably want to do this without any hardcoding as well:

  let defaultParent = require("appSupport").defaultToolbarPosition.parent;
  if (!defaultParent)
    ...
  let toolbar = wnd.document.getElementById(defaultParent);
  if (!toolbar)
    ...
  let toolbox = toolbar.toolbox;

http://codereview.adblockplus.org/5390879414026240/diff/5657382461898752/chro...
chrome/content/tests/ui/icon_position.js:44: const DEFUALT =
require("appSupport").defaultToolbarPosition.parent;
This is misspelled. Still, I would prefer a proper variable name, e.g.
defaultParent.

[Wladimir Palant, 2014-07-31 18:32:59]

LGTM