Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5395911630913536: Added PyInstaller spec to create stand-alone CMS builds (Closed)

Created:
Dec. 12, 2013, 11:17 a.m. by Wladimir Palant
Modified:
Dec. 17, 2013, 1:31 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Added PyInstaller spec to create stand-alone CMS builds

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M .hgignore View 1 chunk +2 lines, -0 lines 0 comments Download
A sitescripts/cms/bin/runserver.py View 1 1 chunk +11 lines, -0 lines 0 comments Download
A sitescripts/cms/runserver.spec View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 12, 2013, 11:17 a.m. (2013-12-12 11:17:59 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5395911630913536/diff/5629499534213120/sitescripts/cms/bin/runserver.py File sitescripts/cms/bin/runserver.py (right): http://codereview.adblockplus.org/5395911630913536/diff/5629499534213120/sitescripts/cms/bin/runserver.py#newcode10 sitescripts/cms/bin/runserver.py:10: sys.argv[1:] = ["."] I would prefer to use os.curdir ...
Dec. 12, 2013, 12:59 p.m. (2013-12-12 12:59:00 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5395911630913536/diff/5629499534213120/sitescripts/cms/runserver.spec File sitescripts/cms/runserver.spec (right): http://codereview.adblockplus.org/5395911630913536/diff/5629499534213120/sitescripts/cms/runserver.spec#newcode6 sitescripts/cms/runserver.spec:6: hiddenimports=[], On 2013/12/12 12:59:00, sebastian wrote: > Why don't ...
Dec. 16, 2013, 1:03 p.m. (2013-12-16 13:03:55 UTC) #3
Sebastian Noack
Dec. 16, 2013, 2 p.m. (2013-12-16 14:00:52 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld