Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5398934247702528: Filter Preferences: Template conditions not evaluating to a boolean are interpreted as true (Closed)

Created:
March 12, 2014, 10:43 a.m. by Wladimir Palant
Modified:
March 13, 2014, 4:56 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

The generic mechanism resolving attribute values has to be adapted a bit for conditionals - once the value has been stringified getting a boolean out of it is no longer possible.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/content/ui/filters.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
March 12, 2014, 10:43 a.m. (2014-03-12 10:43:25 UTC) #1
Thomas Greiner
March 13, 2014, 4:11 p.m. (2014-03-13 16:11:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld